Conversation
|
|
||
| if root_only { | ||
| let is_root = UserInputQuery { | ||
| user_text: "NOT is_root:false".to_string(), |
There was a problem hiding this comment.
why not is_root:true ? Why not a term query? Is this in v1?
There was a problem hiding this comment.
https://github.com/quickwit-oss/quickwit/blob/main/quickwit/quickwit-jaeger/src/lib.rs#L322 same in v1 implementation
I don't think a term query is appropriate because, if I understand correctly, a term query searches for fields where is_root is false, or in cases where there are child spans, the field does not exist
| default_operator: BooleanOperand::And, | ||
| lenient: true, | ||
| }; | ||
| let mut new_query = BoolQuery::default(); |
There was a problem hiding this comment.
nitpick: BooleanQuery::intersection
There was a problem hiding this comment.
I can't find the BoolQuery::intersection method, are you sure it exists?
There was a problem hiding this comment.
my bad. that's probably only in tantivy
fulmicoton
left a comment
fulmicoton
left a comment
There was a problem hiding this comment.
A couple of nitpicks here and there.
nico34638
force-pushed
the
jaegerv2
branch
2 times, most recently
from
59bf2ed to
d751ce6
Compare
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Co-authored-by: Paul Masurel <paul@quickwit.io>
2 participants
Description
Jaeger has a new specification for the GRPC remote storage API. They have removed the old version from release 2.6 onwards
https://github.com/jaegertracing/jaeger/tree/v2.13.0/internal/storage/v2/grpc
How was this PR tested?
I add unit test for grpc endpoint and new helper function. And I tested the features with the latest version of Jaeger, and everything works fine.